gh-106482: Clarify documentation of character set in RE #106517
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serhiy-storchaka
added
docs
vadmium
reviewed
Jul 9, 2023
|
Please see my comments in #106482. |
Co-authored-by: Martin Panter <[email protected]>
serhiy-storchaka
added
needs backport to 3.13
|
Even though this didn’t satisfy the original reporter, I think the current changes are still an improvement over the current wording, and worth merging. |
hugovk
approved these changes
Apr 10, 2025
|
Thanks @serhiy-storchaka for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Apr 10, 2025
…GH-106517) (cherry picked from commit 1557da6) Co-authored-by: Serhiy Storchaka <[email protected]> Co-authored-by: Martin Panter <[email protected]> Co-authored-by: Hugo van Kemenade <[email protected]>
|
GH-132365 is a backport of this pull request to the 3.13 branch. |
hugovk
added a commit
that referenced
this pull request
Apr 10, 2025
…6517) (#132365) Co-authored-by: Serhiy Storchaka <[email protected]> Co-authored-by: Martin Panter <[email protected]> Co-authored-by: Hugo van Kemenade <[email protected]>
seehwan
pushed a commit
to seehwan/cpython
that referenced
this pull request
Apr 16, 2025
…#106517) Co-authored-by: Martin Panter <[email protected]> Co-authored-by: Hugo van Kemenade <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📚 Documentation preview 📚: https://cpython-previews--106517.org.readthedocs.build/